Skip to content

Conversation

@TeofilC
Copy link
Contributor

@TeofilC TeofilC commented Dec 19, 2024

No description provided.

@TeofilC TeofilC changed the title Bump base bounds (GHC-9.12) Bump base bound (GHC-9.12) Dec 19, 2024
@ocharles
Copy link
Contributor

Generally I've done these with a Haskell.nix bump to prove it does work this version of base

@TeofilC
Copy link
Contributor Author

TeofilC commented Dec 20, 2024

Good shout I'll do that

@TeofilC
Copy link
Contributor Author

TeofilC commented Dec 20, 2024

No support for GHC-9.12 from haskell.nix yet. I imagine this will take a while. I'll come back to it in the new year

@TeofilC TeofilC force-pushed the wip/teo/support-ghc-9.12 branch 2 times, most recently from e0058c1 to 81ecb4d Compare May 14, 2025 16:30
@JackKelly-Bellroy
Copy link
Contributor

I was just about to raise a PR like this one - haskell.nix now supports GHC 9.12. Could we please also have a metadata revision if master hasn't changed too much?

@TeofilC
Copy link
Contributor Author

TeofilC commented Aug 21, 2025

We depend on ansi-wl-pprint and that doesn't build with GHC-9.12

@JackKelly-Bellroy
Copy link
Contributor

I don't think this is a problem any more. I tested on rel8 revision 0e1acf0:

[~/code/bellroy/rel8]$ git diff
diff --git a/flake.nix b/flake.nix
index 5af46be..54f21dd 100644
--- a/flake.nix
+++ b/flake.nix
@@ -28,7 +28,7 @@
         };
 
         rel8 = pkgs.haskell-nix.project {
-          compiler-nix-name = "ghc982";
+          compiler-nix-name = "ghc912";
 
           cabalProjectLocal = builtins.readFile ./cabal.project.haskell-nix;
 
diff --git a/rel8.cabal b/rel8.cabal
index 6aa8de7..4044dee 100644
--- a/rel8.cabal
+++ b/rel8.cabal
@@ -21,7 +21,7 @@ library
   build-depends:
       aeson
     , attoparsec
-    , base ^>= 4.16 || ^>= 4.17 || ^>= 4.18 || ^>= 4.19 || ^>= 4.20
+    , base ^>= 4.16 || ^>= 4.17 || ^>= 4.18 || ^>= 4.19 || ^>= 4.20 || ^>= 4.21
     , base16 >= 1.0
     , base-compat ^>= 0.11 || ^>= 0.12 || ^>= 0.13 || ^>= 0.14
     , bifunctors

[~/code/bellroy/rel8]$ nix flake update
-snip output-

[~/code/bellroy/rel8]$ nix develop
-snip output-

[~/code/bellroy/rel8]$ cabal test
-snip output-
All 105 tests passed (32.73s)
Test suite tests: PASS
Test suite logged to:
~/code/bellroy/rel8/./dist-newstyle/build/x86_64-linux/ghc-9.12.2/rel8-1.7.0.0/t/tests/test/rel8-1.7.0.0-tests.log
1 of 1 test suites (1 of 1 test cases) passed.

I see that tmp-postgres depends on ansi-wl-pprint, but it looks like ansi-wl-pprint-1.0.2 is just a re-export of prettyprinter-compat-ansi-wl-pprint:

Deprecated: Compatibility module for users of ansi-wl-pprint - use Prettyprinter instead

@TeofilC TeofilC force-pushed the wip/teo/support-ghc-9.12 branch from 81ecb4d to 752eda9 Compare August 26, 2025 08:09
@TeofilC
Copy link
Contributor Author

TeofilC commented Aug 26, 2025

Thanks! I think it should be working now

@TeofilC TeofilC force-pushed the wip/teo/support-ghc-9.12 branch from 752eda9 to bea804a Compare August 26, 2025 08:10
@TeofilC
Copy link
Contributor Author

TeofilC commented Aug 26, 2025

I have published a revision @JackKelly-Bellroy

@TeofilC TeofilC force-pushed the wip/teo/support-ghc-9.12 branch from bea804a to 2b46262 Compare August 26, 2025 08:18
@TeofilC TeofilC merged commit d011ae9 into master Aug 27, 2025
2 of 3 checks passed
@TeofilC TeofilC deleted the wip/teo/support-ghc-9.12 branch August 27, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants