Skip to content

Conversation

@ocharles
Copy link
Contributor

This renders a selection dropdown with the item class, suitable for
use in ui menu components.

This renders a selection dropdown with the `item` class, suitable for
use in `ui menu` components.
[ ( "compact", compact ), ( "selection", True ) ]

MenuItem ->
[ ( "inline", True ), ( "item", True ) ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see inline in the semantic ui examples for this - possible it's specific to the menu you're building?

@rehno-lindeque
Copy link
Contributor

rehno-lindeque commented Dec 18, 2019

I'm ok with this PR as is, though I think it's possible you may want to have it as

module Menu.Item

type Config = { active : Bool, inline : Bool }
module Dropdown

type Variation msg
  = Ordinary
  | Item (Menu.Item.Config msg) -- Config from Menu.Item...
  | Button (Button.Config msg) -- ...similar to this

because the order in which classes are applied appears to matter, so technically it would need to be

ui ...(dropdown classes)... dropdown ....(item classes)... item

(though often, but not always, a random order works by accident)

See:

for how it works with button at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants