fix(docs): Correct README clone URL and directory to circlefin/arc-nanopayments#13
Open
Sertug17 wants to merge 1 commit into
Open
fix(docs): Correct README clone URL and directory to circlefin/arc-nanopayments#13Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
…nopayments The clone command in the README references both an internal repository name (akelani-circle/arc-nanopayments-demo) and a stale directory name that returns 404 for new contributors. The correct public repository is circlefin/arc-nanopayments and the cd path should match. Same akelani-circle/... pattern previously identified across other Arc sample apps: - arc-fintech#9 (by skyc1e) - arc-escrow#16 (by me) - arc-p2p-payments#9 (by me)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README's "Getting Started" section references both an internal repository name and a stale directory name in the clone command, which returns 404 for new contributors:
git clone https://github.com/akelani-circle/arc-nanopayments-demo.git cd arc-nanopayments-demoThe correct public repository is
circlefin/arc-nanopaymentsand thecdpath should match. This blocks the entire setup flow on the very first step.Change
Verification
Related
The same
akelani-circle/...pattern was identified across other Arc sample apps and addressed in:arc-fintech#9by @skyc1earc-escrow#16by mearc-p2p-payments#9by meThis PR completes the same minimal fix across the public Arc sample app repositories.
Notes
akelani-circle→circlefin) and the repo name (arc-nanopayments-demo→arc-nanopayments) need correcting, hence thecdline also changes.