-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Server release 4.9 docs #9728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server release 4.9 docs #9728
Conversation
* Add docs on how to go from 4.4 to 7.0 * style and formatting * Add curly brackets around manual response --------- Co-authored-by: rosie yohannan <[email protected]>
* adding client block to values.yaml * added nomad client privateKey * Update docs/server-admin-4.9/modules/ROOT/partials/installation/phase-3.adoc Co-authored-by: Rosie Yohannan <[email protected]> --------- Co-authored-by: Atul S <[email protected]> Co-authored-by: Rosie Yohannan <[email protected]>
…ipt (#9806) * Replace hardcoded server image list with extraction script This script pulls the current image list from the Helm chart, keeping it up-to-date with server releases and reduce maintenance overhead. * allow attribute substitution * consistent syntax for substitution --------- Co-authored-by: rosie yohannan <[email protected]>
* Update server values table for 4.9 * fix include --------- Co-authored-by: rosie yohannan <[email protected]>
docs/server-admin-4.8/modules/operator/pages/configuring-external-services.adoc
Outdated
Show resolved
Hide resolved
docs/server-admin-4.8/modules/operator/pages/configuring-external-services.adoc
Outdated
Show resolved
Hide resolved
…nal-services.adoc Co-authored-by: Atul S <[email protected]>
…nal-services.adoc Co-authored-by: Atul S <[email protected]>
marcospereira-circleci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rosieyohannan, a few minor suggestions, but nothing that blocks merging the PR.
Also, I understand that the 4.9 pages were copied from 4.8 after those changes, right? Do we need to sync those suggestions/changes back into the 4.9 pages then?
docs/server-admin-4.8/modules/ROOT/partials/installation/phase-2.adoc
Outdated
Show resolved
Hide resolved
| serverversion48: 4.8.5 | ||
| serverversion: 3.4.8 | ||
| serverversion49: 4.9.0 | ||
| terraformversion: 0.15.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are here...
@atulsingh0, does this version still make sense? This is supposed to be the minimal version supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version gets updated when patch releases go out which updates the version quoted in various places across the docs
…-2.adoc Co-authored-by: Marcos Pereira <[email protected]>
I have one ticket actually to bring over a change from 4.8 (https://circleci.atlassian.net/browse/DOCSS-1982?atlOrigin=eyJpIjoiNDkxYzczMWMyOGVhNDhlOGI3NzNmM2RmYzUwYmJkZjYiLCJwIjoiaiJ9) So I will do that one today. I'll check in github for other changes that have happened in 4.8 docs since the 4.9 branch was created too |
Description
What did you change?
Reasons
Why did you make these changes?
Content Checklist
Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.
Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs):