Skip to content

add EntityResolver to ignore externally referenced dtd files #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhursty merged 2 commits into from
Dec 2, 2025
Merged

add EntityResolver to ignore externally referenced dtd files #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dd3b79
add EntityResolver to ignore externally referenced dtd files
Jason-elkins Dec 1, 2025
346e0ab
fix: use a stack varialbe instead and do not validate
Jason-elkins Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/KM_xml.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,15 @@ Kumu::XMLElement::ParseString(const char* document, ui32_t doc_len)
return errorCount > 0 ? false : true;
}


class IgnoreDTDResolver : public xercesc::EntityResolver {
public:
InputSource* resolveEntity(const XMLCh* const, const XMLCh* const) override {
static const XMLByte dummy[] = "";
return new xercesc::MemBufInputSource(dummy, 0, "dummy-dtd", false);
}
};

//
bool
Kumu::XMLElement::ParseFirstFromString(const char* document, ui32_t doc_len)
Expand All @@ -1002,14 +1011,18 @@ Kumu::XMLElement::ParseFirstFromString(const char* document, ui32_t doc_len)
int errorCount = 0;
SAXParser* parser = new SAXParser();

parser->setValidationScheme(SAXParser::Val_Always);
parser->setValidationScheme(SAXParser::Val_Never);
parser->setDoNamespaces(true); // optional

MyTreeHandler* docHandler = new MyTreeHandler(this);
parser->setDocumentHandler(docHandler);
parser->setErrorHandler(docHandler);
XMLPScanToken token;

// Ignore references to DTD files
IgnoreDTDResolver resolver;
parser->setEntityResolver(&resolver);

try
{
MemBufInputSource xmlSource(reinterpret_cast<const XMLByte*>(document),
Expand Down