Skip to content

Fix non-standard format specifiers #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhursty merged 2 commits into from
Jul 10, 2025
Merged

Fix non-standard format specifiers #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c764338
fix: format specifiers that are not portable
Jason-elkins Jul 9, 2025
572ae6c
Merge branch 'cinecert:master' into fix_format_specifier
Jason-elkins Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/KM_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,11 @@ namespace Kumu
};
#else
struct i64Printer : public IntPrinter<i64_t, 32> {
i64Printer(i64_t value) : IntPrinter<i64_t, 32>("%qd", value) {}
i64Printer(i64_t value) : IntPrinter<i64_t, 32>("%lld", value) {}
};

struct ui64Printer : public IntPrinter<ui64_t, 32> {
ui64Printer(ui64_t value) : IntPrinter<ui64_t, 32>("%qu", value) {}
ui64Printer(ui64_t value) : IntPrinter<ui64_t, 32>("%llu", value) {}
};
#endif

Expand Down
4 changes: 2 additions & 2 deletions src/MXF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,11 +794,11 @@ ASDCP::MXF::OP1aHeader::InitFromFile(const Kumu::IFileReader& Reader)
}
else if ( HeaderByteCount < 1024 )
{
DefaultLogSink().Warn("Improbably small HeaderByteCount value: %qu\n", HeaderByteCount);
DefaultLogSink().Warn("Improbably small HeaderByteCount value: %llu\n", HeaderByteCount);
}
else if (HeaderByteCount > ( 4 * Kumu::Megabyte ) )
{
DefaultLogSink().Warn("Improbably huge HeaderByteCount value: %qu\n", HeaderByteCount);
DefaultLogSink().Warn("Improbably huge HeaderByteCount value: %llu\n", HeaderByteCount);
}

result = m_HeaderData.Capacity(Kumu::xmin(4*Kumu::Megabyte, static_cast<ui32_t>(HeaderByteCount)));
Expand Down
2 changes: 1 addition & 1 deletion src/klvwalk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ main(int argc, const char** argv)

if ( plain_part.ThisPartition != i->ByteOffset )
{
DefaultLogSink().Error("ThisPartition value error: wanted=%qu, got=%qu\n",
DefaultLogSink().Error("ThisPartition value error: wanted=%llu, got=%llu\n",
plain_part.ThisPartition, i->ByteOffset);
}

Expand Down