feat: support program run batching with new BatchSize option #1914
+460
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takehaya
force-pushed
the
feat/add_batch_size
branch
from
c9124a8 to
684226f
Compare
ti-mo
requested changes
Dec 2, 2025
takehaya
force-pushed
the
feat/add_batch_size
branch
3 times, most recently
from
33ddffb to
886a64a
Compare
Contributor
Author
Contributor
Author
|
It feels like this failing test has nothing to do with mine, and it just looks like a very quirky one....
|
Member
No, not your fault. Its a persistent flake we have not been able to figure out yet. |
Contributor
Author
|
That is a bit of a problem....😫 |
ti-mo
reviewed
Dec 4, 2025
ti-mo
previously approved these changes
Dec 4, 2025
Collaborator
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
Very cool, thanks for taking the time for adding a nice example!
Left one nit. Also, please don't forget to squash your 2nd commit into the 1st. 😄
Signed-off-by: Takeru Hayasaka <[email protected]>
Signed-off-by: Takeru Hayasaka <[email protected]>
takehaya
force-pushed
the
feat/add_batch_size
branch
from
886a64a to
a3db07c
Compare
Contributor
Author
|
@ti-mo san Thanks for the review. I squashed this commit too. Ready to merge now, please check! 🙏 |
Collaborator
|
@takehaya Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds BatchSize to RunOptions and plumbs it through to sys.ProgRunAttr.BatchSize, enabling multiple program executions per single
BPF_PROG_RUNsyscall.Motivation
In cases where the call overhead is high, such as with
BPF_F_TEST_XDP_LIVE_FRAMES, this option becomes desirable.I am developing my own packet generator, and I found that I need this feature for optimization.
I would be very happy if this could be accepted.