makes most operators hidden friends #471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that they're not placed in their function names' respecitve overload sets, which has a considerable impact on build times and on compiler diagnostics (as they're not listed as failed candidates when overload resolution fails).
Running an include tracer indicated that placing `size_hint_impl.h` in this header should prevent link-time errors when attempting to incidentally format `SizeHint`.
cjdb
force-pushed
the
hidden-friend-operators
branch
from
c8fe86b to
438c023
Compare
danakj
reviewed
May 7, 2025
| @@ -748,6 +748,47 @@ _sus_pure constexpr _self _self::from_ne_bytes( | |||
| return _self(val); | |||
| } | |||
|
|
|||
| _sus_pure constexpr u32 _self::count_ones() const& noexcept { | |||
| return __private::count_ones(primitive_value); | |||
There was a problem hiding this comment.
Why did these bodies need to move?
There was a problem hiding this comment.
u32 needs to be a complete type, and u64 is needed in u32, so these need to follow both types' definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that they're not placed in their function names' respective overload sets, which has a considerable impact on build times and on compiler diagnostics (as they're not listed as failed candidates when overload resolution fails).