Skip to content

Conversation

@ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Nov 28, 2025

This is a breaking change. Due to dependency on Storybook 10.1 components, it is incompatible with Storybook 10.0 or before.

  • Upgraded the Storybook dependency to v10.1
  • Updates the addon UI to use Storybook 10.1 UI components for a consistent look
  • Fixed various accessibility issues and minor UI issues
  • Fixed play functions that interact with popovers

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 0.55659% with 536 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.16%. Comparing base (bf78815) to head (e46307b).
⚠️ Report is 2 commits behind head on next.

Files with missing lines Patch % Lines
src/screens/VisualTests/SnapshotControls.tsx 0.00% 181 Missing ⚠️
src/components/FooterMenu.tsx 0.00% 63 Missing and 1 partial ⚠️
src/components/ModeSelector.tsx 0.00% 53 Missing and 1 partial ⚠️
src/components/BrowserSelector.tsx 2.04% 48 Missing ⚠️
src/utils/playAll.ts 0.00% 32 Missing ⚠️
src/TestProviderRender.tsx 0.00% 22 Missing ⚠️
src/screens/VisualTests/NoBuild.tsx 0.00% 18 Missing ⚠️
...c/screens/VisualTests/SnapshotControls.stories.tsx 0.00% 12 Missing ⚠️
src/screens/VisualTests/BuildEyebrow.tsx 0.00% 11 Missing ⚠️
...screens/VisualTests/SnapshotComparison.stories.tsx 0.00% 11 Missing ⚠️
... and 24 more
Additional details and impacted files
@@           Coverage Diff            @@
##            next    #396      +/-   ##
========================================
+ Coverage   6.03%   6.16%   +0.13%     
========================================
  Files        168     161       -7     
  Lines      14284   13934     -350     
  Branches     300     293       -7     
========================================
- Hits         862     859       -3     
+ Misses     13341   12998     -343     
+ Partials      81      77       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghengeveld ghengeveld added major Auto: Increment the major version when merged and removed minor Auto: Increment the minor version when merged labels Dec 5, 2025
@ghengeveld ghengeveld force-pushed the upgrade-storybook-10-1 branch from e46307b to 32f9d6a Compare December 12, 2025 11:01
Comment on lines 5 to 8
export default {
...config,
managerEntries: [require.resolve('./manager.tsx')],
managerEntries: [fileURLToPath(import.meta.resolve('./manager.tsx'))],
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot like a preset file, is it? Hard to tell from just looking at the diff.
If it is, can we rename it to preset.ts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major Auto: Increment the major version when merged release Auto: Create a `latest` release when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants