Skip to content

[CLN]: make materialization function rather than struct #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2024
Merged

[CLN]: make materialization function rather than struct #3165

merged 2 commits into from
Dec 2, 2024

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Nov 20, 2024 •
edited
Loading

Description of changes

Simplifies usage of log materialization logic & lifetimes in preparation for next PR in this stack. There are no actual logic changes.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb Graphite App
Copy link
Contributor Author

codetheweb commented Nov 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codetheweb codetheweb mentioned this pull request Nov 20, 2024
Closed
1 task
@codetheweb codetheweb marked this pull request as ready for review November 20, 2024 00:57
@codetheweb codetheweb force-pushed the cln-materialize-method branch from ea68456 to 60a56af Compare November 20, 2024 22:59
This was referenced Nov 20, 2024
Closed
Closed
@codetheweb codetheweb force-pushed the cln-materialize-method branch from 60a56af to 3bc5002 Compare November 21, 2024 18:32
@codetheweb codetheweb force-pushed the cln-materialize-method branch from 3bc5002 to db8bf19 Compare December 1, 2024 23:35
@codetheweb Graphite App
Copy link
Contributor Author

codetheweb commented Dec 2, 2024 •
edited
Loading

Merge activity

  • Dec 1, 7:14 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 1, 7:15 PM EST: A user merged this pull request with Graphite.

@codetheweb codetheweb merged commit ccff355 into main Dec 2, 2024
72 checks passed
@codetheweb codetheweb deleted the cln-materialize-method branch December 2, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codetheweb @HammadB