Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: force disconnect from virtual busses on tearDown() (fixes #530) #535

Conversation

erlend-aasland
Copy link
Contributor

No description provided.

@erlend-aasland erlend-aasland marked this pull request as ready for review August 14, 2024 08:05
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.90%. Comparing base (932c621) to head (40a5141).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   71.10%   70.90%   -0.20%     
==========================================
  Files          26       26              
  Lines        3111     3111              
  Branches      526      526              
==========================================
- Hits         2212     2206       -6     
- Misses        769      778       +9     
+ Partials      130      127       -3     

see 2 files with indirect coverage changes

@acolomb
Copy link
Collaborator

acolomb commented Aug 14, 2024

This seems to cut about half the time for build checks. Still would prefer a customizable solution that is useful beyond the unit tests, see my comment in #530 and PR #536.

@acolomb acolomb changed the title Tests: force disconnect from virtual busses on tearDown() Tests: force disconnect from virtual busses on tearDown() (fixes #530) Aug 14, 2024
@acolomb acolomb linked an issue Aug 14, 2024 that may be closed by this pull request
@erlend-aasland erlend-aasland deleted the gh-530/speed-up-tests branch August 14, 2024 10:32
@erlend-aasland
Copy link
Contributor Author

Closed in favour of #536.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce network shutdown latency
3 participants