Tests: harden test_emcy_consumer_wait #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait a little bit longer before dispatching the EMCY packet, and start the one-shot timer just before invoking the wait() call.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
=======================================
Coverage 71.10% 71.10%
=======================================
Files 26 26
Lines 3111 3111
Branches 526 526
=======================================
Hits 2212 2212
Misses 769 769
Partials 130 130 |
|
I'll just run the checks a few times now before merging. |
Hold it a little bit; I'd like to also add resource management (joining). |
acolomb
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait a little bit longer before dispatching the EMCY packet, and start
the one-shot timer just before invoking the wait() call.