Ignore commas when sorting by currency#47
Closed
dougjohnston wants to merge 1 commit into
Closed
Conversation
Collaborator
|
This change is not a good idea... some countries use the comma and decimal point the opposite of how it is used in the U.S. (e.g. |
Author
|
Fair point. For our project, we only deal in USD, so it wasn't something I thought of. Would there be a more suitable fix that accommodates more countries? The current sorting approach (not ignoring commas) doesn't work for columns of currency values. Eg: $1,995 |
Author
|
I see now that this is a duplicate of #34. That one seems like a better fix because the comma is not hard-coded and the value is configurable. That seems to solve the issue you brought up, no? |
Collaborator
|
Yeah, I left a comment in that issue on how I solved the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sorting by currency, ignore commas for a proper sort. Fixes issue #43.