[Skia] Fix hazeSource content changes not updating hazeEffects #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
force-pushed
the
cb/changing-background
branch
2 times, most recently
from
8d9885d to
6bba288
Compare
chrisbanes
force-pushed
the
cb/changing-background
branch
from
6bba288 to
2862d89
Compare
chrisbanes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two related issues which this PR fixes:
Snapshot.withoutReadObservation. This was done to avoid unwanted invalidations in Haze, but it has the knock-on effect that it breaks internal invalidation in the Skiko GraphicsLayer impl. Fixed by usingwithoutReadObservationmore locally around state reads.HazeArea.contentLayer. This probably isn't the root cause of this issue, but this is more defensive for the future.Fixes #475