Skip to content

Fix call to logging._level #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix call to logging._level #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8caa4e2
fixed call to logging._level
TomHodson Apr 6, 2023
c72c6c5
apply logLevel to correct logger
TomHodson Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ina219.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ def __init__(self, shunt_ohms, i2c, max_expected_amps=None,
log_level -- set to logging.DEBUG to see detailed calibration
calculations (optional).
"""
logging.basicConfig(level=log_level)
Copy link
Owner

@chrisb2 chrisb2 Apr 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should follow the pattern in the RPi version of this library and check if the logger is already setup, see RPi ina219.py, which was made in this PR?

self._log = logging.getLogger("ina219")
self._log.setLevel(log_level)
self._i2c = i2c
self._address = address
self._shunt_ohms = shunt_ohms
Expand Down Expand Up @@ -406,7 +406,7 @@ def __read_register(self, register, negative_value_supported=False):

def __log_register_operation(self, msg, register, value):
# performance optimisation
if logging._level == logging.DEBUG:
if self._log.level == logging.DEBUG:
binary = '{0:#018b}'.format(value)
self._log.debug("%s register 0x%02x: 0x%04x %s",
msg, register, value, binary)
Expand Down