Repository navigation
Fix error in ReversePropagationGuidedNeighborhood - #1239
Merged
Merged
Conversation
+ update Javadoc
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
ArthurGodet
approved these changes
Aug 31, 2026
jgFages
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix wraps the propagation call in a try-catch block within the
update()method.When freezing a variable to its solution value and propagating, a contradiction can occur (e.g., due to a cut on the objective function invalidating that value).
The try-catch silently handles this, allowing the algorithm to continue processing remaining variables. The variable is still removed from the fragment (fragment.clear(id) executes afterward), ensuring the fragment is properly adjusted when such contradictions arise.
Therefore, if an exception is raised, it will be raised once the variables have actually been set, and not before.
This PR fixes the remaining bug in #1238