Add Ideal Rankine Cycle jupyter notebook tutorial#82
Open
adriaan90 wants to merge 1 commit intochmarti1:masterfrom
Open
Add Ideal Rankine Cycle jupyter notebook tutorial#82adriaan90 wants to merge 1 commit intochmarti1:masterfrom
adriaan90 wants to merge 1 commit intochmarti1:masterfrom
Conversation
Owner
|
Thanks so much for contributing your code and your time! I won't be able to give it the attention it deserves for a little while. I will. In the meantime, thanks very much for your work, and thanks for using PYroMat! |
Author
|
@chmarti1 I see it has been more than a year since I created the pull request. Please do not hesitate to let me know of any shortfalls that I need to address for this pull request to be successful. Thanks |
Owner
|
It's been a long time - that's true. I've been working to get through the mounting to-do list for the project. These pull requests are still on my to-do list, but they aren't the most urgent yet. Please know I really do value your work. I'm planning to circle around with the rest of the team soon and discuss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
I saw in the discussions under the Ideas section the need for a tutorial in the jupyter notebook format. The Ideal Rankine Cycle is an appropriate problem to use to showcase the use of PYroMat.
I am happy to make changes as required by you.
Thank you for the opportunity
Adriaan van Niekerk