Merge pull request #23 from chizmw/showcase-fixes

Showcase fixes
chizmw · Apr 17, 2023 · cbb208d · cbb208d
2 parents a34e881 + b3714b9
commit cbb208d
Show file tree

Hide file tree

Showing 20 changed files with 25 additions and 1 deletion.
diff --git a/.changes/unreleased/Added-20230417-143110.yaml b/.changes/unreleased/Added-20230417-143110.yaml
@@ -0,0 +1,5 @@
+kind: Added
+body: check files generated in 'generate pdfs' workflow
+time: 2023-04-17T14:31:10.238179+01:00
+custom:
+  GithubIssue: ""
diff --git a/.changes/unreleased/Changed-20230417-143045.yaml b/.changes/unreleased/Changed-20230417-143045.yaml
@@ -0,0 +1,5 @@
+kind: Changed
+body: manually regenerate sample PNGs
+time: 2023-04-17T14:30:45.727602+01:00
+custom:
+  GithubIssue: ""
diff --git a/.changes/unreleased/Changed-20230417-143129.yaml b/.changes/unreleased/Changed-20230417-143129.yaml
@@ -0,0 +1,5 @@
+kind: Changed
+body: don't trigger workflows because of generated/ files
+time: 2023-04-17T14:31:29.607635+01:00
+custom:
+  GithubIssue: ""
diff --git a/.changes/unreleased/Fixed-20230417-143151.yaml b/.changes/unreleased/Fixed-20230417-143151.yaml
@@ -0,0 +1,5 @@
+kind: Fixed
+body: open the jink player sheet preview in the readme by default
+time: 2023-04-17T14:31:51.404179+01:00
+custom:
+  GithubIssue: ""
diff --git a/.github/workflows/generate-samples.yml b/.github/workflows/generate-samples.yml
@@ -29,6 +29,7 @@ jobs:
         shell: bash
         run: |
           make grab-some-scripts
+          ls -larth scripts
 
       - name: Generate samples
         shell: bash
@@ -37,6 +38,7 @@ jobs:
         run: |
           sudo apt-get install -y poppler-utils
           make all-scripts
+          ls -larth generated/*
 
       # and eventually we'll create a PR for this
       # but we need to make sure we don't end up in a loop

diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml
@@ -2,6 +2,8 @@
 # yamllint disable-line rule:truthy
 on:
   pull_request:
+    paths-ignore:
+      - '**/generated/**'
 
 name: pre-commit
 

diff --git a/README.md b/README.md
@@ -107,7 +107,7 @@ This script was generated purely to have something to test our output with
 jinxes in a script. There are probably more than you'd really want, or have, in
 a legit custom script so don't panic if it's slightly weird in places...
 
-<details><summary>Let's Test Some Jinxes - Player Sheet</summary>
+<details open><summary>Let's Test Some Jinxes - Player Sheet</summary>
 <a href="generated/Let's Test Some Jinxes/Let's Test Some Jinxes-p1.png"><img src="generated/Let's Test Some Jinxes/Let's Test Some Jinxes-p1.png" width="100%"></a>
 </details>
 

diff --git a/generated/Let's Test Some Jinxes/Let's Test Some Jinxes-p1.png b/generated/Let's Test Some Jinxes/Let's Test Some Jinxes-p1.png
diff --git a/generated/Let's Test Some Jinxes/Let's Test Some Jinxes-p2.png b/generated/Let's Test Some Jinxes/Let's Test Some Jinxes-p2.png
diff --git a/generated/Let's Test Some Jinxes/Let's Test Some Jinxes-p3.png b/generated/Let's Test Some Jinxes/Let's Test Some Jinxes-p3.png
diff --git a/generated/Let's Test Some Jinxes/Let's Test Some Jinxes.pdf b/generated/Let's Test Some Jinxes/Let's Test Some Jinxes.pdf
diff --git a/generated/No Roles Barred/No Roles Barred-p1.png b/generated/No Roles Barred/No Roles Barred-p1.png
diff --git a/generated/No Roles Barred/No Roles Barred-p2.png b/generated/No Roles Barred/No Roles Barred-p2.png
diff --git a/generated/No Roles Barred/No Roles Barred-p3.png b/generated/No Roles Barred/No Roles Barred-p3.png
diff --git a/generated/Reptiles!/Reptiles!-p1.png b/generated/Reptiles!/Reptiles!-p1.png
diff --git a/generated/Reptiles!/Reptiles!-p2.png b/generated/Reptiles!/Reptiles!-p2.png
diff --git a/generated/Reptiles!/Reptiles!-p3.png b/generated/Reptiles!/Reptiles!-p3.png
diff --git a/generated/Trouble Brewing/Trouble Brewing-p1.png b/generated/Trouble Brewing/Trouble Brewing-p1.png
diff --git a/generated/Trouble Brewing/Trouble Brewing-p2.png b/generated/Trouble Brewing/Trouble Brewing-p2.png
diff --git a/generated/Trouble Brewing/Trouble Brewing-p3.png b/generated/Trouble Brewing/Trouble Brewing-p3.png