Merge pull request #29 from chizmw/remote-json-fetch-fixes

Remote json fetch fixes

.changes/unreleased/Fixed-20230418-003009.yaml

@@ -0,0 +1,5 @@
+kind: Fixed
+body: add timeout to requests.get()
+time: 2023-04-18T00:30:09.690116+01:00
+custom:
+  GithubIssue: ""

.changes/unreleased/Fixed-20230418-003058.yaml

@@ -0,0 +1,5 @@
+kind: Fixed
+body: exit(…) -> sys.exit(…)
+time: 2023-04-18T00:30:58.196572+01:00
+custom:
+  GithubIssue: ""

botcpdf/main.py

@@ -14,7 +14,7 @@ def main():
     # if we don't have any args, exit with an error
     if len(sys.argv) == 1:
         print("Usage: botcpdf <scriptname>|<scriptjsonurl>")
-        exit(1)
+        sys.exit(1)
 
     # if our first arg starts with http, assume it's a URL
     if sys.argv[1].startswith("http"):

botcpdf/util.py

@@ -4,13 +4,14 @@
 import shutil
 import sys
 import os
-import requests # type: ignore
+import requests  # type: ignore
 from pdf2image import convert_from_path
 
+
 def fetch_remote_data(url: str):
     """Fetch data from a remote URL."""
 
-    response = requests.get(url)
+    response = requests.get(url, timeout=10, allow_redirects=True)
     response.raise_for_status()
     return response.json()