fix: UI build, MCP test, and governance gate template drift - #89
Conversation
- Add react-is dependency (recharts peer dep) to fix broken UI build - Update MCP tool count test assertion from 48 to 50 to match actual - Sync governance template regex to fix #86 (txt false-positive) - Add audit_omit_dev input to reusable-governance-gates.yml for #88 - Enable audit_omit_dev for chittycommand (Worker repo) - Update CLAUDE.md tool count references to 50 Closes #86, closes #88 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
chittycommand-ui | a9dadad | Apr 14 2026, 04:39 AM |
|
|
To use Codex here, create a Codex account and connect to github. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThese changes address template synchronization and dependency audit behavior by adding an optional Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9dadaddb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set -euo pipefail | ||
| secrets_in_use="$(grep -RhoE 'secrets\.[A-Za-z_][A-Za-z0-9_]*' .github/workflows \ | ||
| | sed -E 's/.*secrets\.([A-Za-z_][A-Za-z0-9_]*).*/\1/' \ | ||
| secrets_in_use="$(grep -RhoE '\$\{\{\s*secrets(\.[A-Za-z_][A-Za-z0-9_]*|\['"'"'\"[A-Za-z_][A-Za-z0-9_]*'"'"'\"\])\s*\}\}' .github/workflows \ |
There was a problem hiding this comment.
The new grep regex only matches when secrets.<NAME> is the entire ${{ ... }} expression, because it requires the secret token to be followed directly by optional spaces and }}. That misses valid usages such as ${{ secrets.API_TOKEN != '' }} or ${{ someFn(secrets.API_TOKEN) }}, so disallowed secrets can bypass the allowlist check in repos generated from this template. The previous secrets\.<NAME> scan still caught those forms, so this change narrows policy coverage.
Useful? React with 👍 / 👎.
1 participant
Summary
react-is(recharts peer dependency) — build was broken without it. Removed staleagentspackage that was uncommitted.txtfalse-positive. Addedaudit_omit_devworkflow input so Worker repos can skip devDependency audit noise.Issues addressed
Validation
npm run typecheck✅npm test✅ (15/15 pass)npm run build(UI) ✅npm audit --omit=dev— 0 vulnerabilities (both backend and UI)reusable-governance-gates.ymlare identical (diffreturns empty)Test plan
audit_omit_dev: true🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Chores