fix: review audit — SQL branching, error distinguishability, try-catch - #65
Conversation
…-catch 1. timeline.ts: apply branched SQL query pattern (matching mcp.ts fix) 2. mcp.ts get_case_timeline: wrap evidence fetch in try-catch, add warnings/partial fields for degraded responses 3. integrations.ts: searchEntries/getChainOfCustody now return ServiceArrayResult<T> with explicit error field so callers can distinguish "no data" from "service unreachable" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
To use Codex here, create a Codex account and connect to github. |
Summary
warnings/partialfields for degraded responses (matching REST timeline pattern)searchEntries/getChainOfCustodynow returnServiceArrayResult<T>with expliciterrorfield so callers can distinguish "no data" from "service unreachable"Test plan
GET /cases/:caseId/timelinereturnswarnings/partialwhen evidence is downget_case_timelinereturnswarnings/partialwhen evidence or DB failssearchEntriesreturns{ data: [], error: '...' }on service failure vs{ data: [] }on empty🤖 Generated with Claude Code