Skip to content

fix: review audit — SQL branching, error distinguishability, try-catch - #65

Merged
chitcommit merged 1 commit into
mainfrom
fix/review-audit-findings
Mar 26, 2026
Merged

chitcommit merged 1 commit into
mainfrom
fix/review-audit-findings

Conversation

@chitcommit

Copy link
Copy Markdown
Contributor

Summary

  • timeline.ts: Apply branched SQL query pattern for conditional WHERE clauses (matches mcp.ts fix from fix: phantom ledger paths, SQL errors, deterministic case refs #60)
  • mcp.ts get_case_timeline: Wrap evidence fetch in try-catch, surface warnings/partial fields for degraded responses (matching REST timeline pattern)
  • integrations.ts: searchEntries/getChainOfCustody now return ServiceArrayResult<T> with explicit error field so callers can distinguish "no data" from "service unreachable"

Test plan

  • Verify GET /cases/:caseId/timeline returns warnings/partial when evidence is down
  • Verify MCP get_case_timeline returns warnings/partial when evidence or DB fails
  • Verify searchEntries returns { data: [], error: '...' } on service failure vs { data: [] } on empty

🤖 Generated with Claude Code

…-catch

1. timeline.ts: apply branched SQL query pattern (matching mcp.ts fix)
2. mcp.ts get_case_timeline: wrap evidence fetch in try-catch, add
   warnings/partial fields for degraded responses
3. integrations.ts: searchEntries/getChainOfCustody now return
   ServiceArrayResult<T> with explicit error field so callers can
   distinguish "no data" from "service unreachable"

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chitcommit
chitcommit merged commit ad4c9e8 into main Mar 26, 2026
10 of 11 checks passed
@coderabbitai

coderabbitai Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@chitcommit has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c26b2cd6-c760-417d-88ec-ddd5a2b3d0b6

📥 Commits

Reviewing files that changed from the base of the PR and between 44800a4 and 50a0e97.

📒 Files selected for processing (3)
  • src/lib/integrations.ts
  • src/routes/mcp.ts
  • src/routes/timeline.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/review-audit-findings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chitcommit
chitcommit deleted the fix/review-audit-findings branch March 26, 2026 00:58
@github-actions

Copy link
Copy Markdown
  1. @coderabbitai review
  2. @copilot review
  3. @codex review
  4. @claude review
    Adversarial review request: evaluate security, policy bypass paths, regression risk, and merge-gating bypass attempts.

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant