Skip to content

fix: error logging, evidence auth, partial data warnings - #63

Merged
chitcommit merged 1 commit into
mainfrom
fix/review-findings
Mar 25, 2026
Merged

chitcommit merged 1 commit into
mainfrom
fix/review-findings

Conversation

@chitcommit

Copy link
Copy Markdown
Contributor

Summary

Addresses findings from comprehensive PR review of #60:

  • CRITICAL: Add error logging to all 11 empty catch blocks across ledgerClient, connectClient.discover, and MCP connect_discover handler
  • IMPORTANT: Add CHITTYEVIDENCE_TOKEN to Env type and Bearer auth to evidence client (was the only service client without auth)
  • IMPORTANT: Return error field from ledger_facts/ledger_contradictions when ChittyEvidence is unconfigured (instead of silently returning empty data)
  • IMPORTANT: Wrap get_case_timeline DB queries in independent try-catch blocks for partial data collection
  • HIGH: Add warnings/partial fields to timeline response when data sources fail
  • MINOR: Fix stale test description ("38 tools" → "48 tools")

Test plan

  • tsc --noEmit passes
  • Verify timeline endpoint includes warnings array when a data source fails
  • Verify evidence client sends Bearer auth when CHITTYEVIDENCE_TOKEN is set
  • Verify MCP ledger_facts returns error field when evidence URL is unset

🤖 Generated with Claude Code

…arnings

- Add console.error/warn to all empty catch blocks in ledgerClient,
  connectClient.discover, and MCP connect_discover handler
- Add CHITTYEVIDENCE_TOKEN to Env type and evidence client auth headers
- Return error field (not empty data) from ledger_facts/contradictions
  when ChittyEvidence is unconfigured
- Wrap get_case_timeline DB queries in try-catch for partial data collection
- Add warnings/partial fields to timeline response when data sources fail
- Fix stale test description (38 → 48 tools)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@chitcommit
chitcommit merged commit 2c0cf24 into main Mar 25, 2026
10 of 11 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chitcommit
chitcommit deleted the fix/review-findings branch March 25, 2026 23:42
@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@chitcommit has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1ba997c4-1db0-4b14-96b9-8e9f36f75331

📥 Commits

Reviewing files that changed from the base of the PR and between 770161c and b25fee5.

📒 Files selected for processing (5)
  • src/index.ts
  • src/lib/integrations.ts
  • src/routes/mcp.ts
  • src/routes/timeline.ts
  • tests/mcp.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/review-findings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
  1. @coderabbitai review
  2. @copilot review
  3. @codex review
  4. @claude review
    Adversarial review request: evaluate security, policy bypass paths, regression risk, and merge-gating bypass attempts.

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant