Skip to content

Commit

Permalink
Fix incorrect FSK datarate multiplication.
Browse files Browse the repository at this point in the history
The HAL and Protobuf messages already contain the bitrate per second.
  • Loading branch information
brocaar committed Nov 27, 2024
1 parent 8084cbd commit 1d29728
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions chirpstack-concentratord-sx1301/src/wrapper/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ pub fn uplink_to_proto(
tx_info.modulation = Some(gw::Modulation {
parameters: Some(gw::modulation::Parameters::Fsk(gw::FskModulationInfo {
datarate: match packet.datarate {
hal::DataRate::FSK(v) => v * 1000,
hal::DataRate::FSK(v) => v,
_ => return Err(anyhow!("unexpected datarate")),
},
..Default::default()
Expand Down Expand Up @@ -345,7 +345,7 @@ pub fn downlink_to_tx_info_proto(packet: &hal::TxPacket) -> Result<gw::DownlinkT
tx_info.modulation = Some(gw::Modulation {
parameters: Some(gw::modulation::Parameters::Fsk(gw::FskModulationInfo {
datarate: match packet.datarate {
hal::DataRate::FSK(v) => v * 1000,
hal::DataRate::FSK(v) => v,
_ => return Err(anyhow!("unexpected datarate")),
},
..Default::default()
Expand Down
4 changes: 2 additions & 2 deletions chirpstack-concentratord-sx1302/src/wrapper/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ pub fn uplink_to_proto(
hal::Modulation::FSK => {
Some(gw::modulation::Parameters::Fsk(gw::FskModulationInfo {
datarate: match packet.datarate {
hal::DataRate::FSK(v) => v * 1000,
hal::DataRate::FSK(v) => v,
_ => return Err(anyhow!("unexpected datarate")),
},
..Default::default()
Expand Down Expand Up @@ -333,7 +333,7 @@ pub fn downlink_to_tx_info_proto(packet: &hal::TxPacket) -> Result<gw::DownlinkT
hal::Modulation::FSK => {
Some(gw::modulation::Parameters::Fsk(gw::FskModulationInfo {
datarate: match packet.datarate {
hal::DataRate::FSK(v) => v * 1000,
hal::DataRate::FSK(v) => v,
_ => return Err(anyhow!("unexpected datarate")),
},
..Default::default()
Expand Down

0 comments on commit 1d29728

Please sign in to comment.