Introductory Price parsing (#186) #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I should have used NSDictionaries instead of switches. Will refactor later. |
|
+1 |
markgardner
reviewed
Sep 25, 2018
| }; | ||
|
|
||
| NSDictionary *introductoryPrice = @{ | ||
| @"price": product.introductoryPrice.price, |
There was a problem hiding this comment.
It would be nice to get the localized price string here. Similar to the product implementation.
There was a problem hiding this comment.
I couldn't add my commits in this PR so I made new one with the changes you requested (#206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing
SKProduct's introductoryPrice if available (on iOS 11.2+), returned as an object with all properties on the native object. Enum's parsed as strings.Tested on iOS 9.3 and 11.4 devices, and iOS 12 emulators with products without introductoryPrice, free trials and pay as you go.
Readme updated