Using uint8 internally to get better performance #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"buildPerformanceButton" what does this screen look like? please put this in a seperate PR but realistically the data must be configurable, as most devices dont have a characteristic that just "ignores" data im not sure ill merge it. |
lib/src/bluetooth_msgs.dart
Outdated
| var rawServiceUuids = json['service_uuids'] ?? []; | ||
| Map<Object?, Object?> rawManufacturerData = json['manufacturer_data'] ?? <int, List<int>>{}; | ||
| Map<Object?, Object?> rawServiceData = json['service_data'] ?? <int, List<int>>{}; | ||
| List<Object?> rawServiceUuids = json['service_uuids'] ?? <String>[]; |
There was a problem hiding this comment.
please use var. Or give it a proper type. not Object.
lib/src/flutter_blue_plus.dart
Outdated
| @@ -746,7 +746,7 @@ class ServiceDataFilter { | |||
| // The 'mask' must have the same length as 'data'. | |||
| List<int> mask; | |||
|
|
|||
| ServiceDataFilter(this.service, {this.data = const [], this.mask = const []}); | |||
| ServiceDataFilter(this.service, {required this.data, required this.mask}); | |||
There was a problem hiding this comment.
this is a breaking change. please undo it.
lib/src/flutter_blue_plus.dart
Outdated
| @@ -726,7 +726,7 @@ class MsdFilter { | |||
| /// The 'mask' must have the same length as 'data'. | |||
| List<int> mask; | |||
|
|
|||
| MsdFilter(this.manufacturerId, {this.data = const [], this.mask = const []}); | |||
| MsdFilter(this.manufacturerId, {required this.data, required this.mask}); | |||
There was a problem hiding this comment.
this is a breaking change. please undo it.
|
|
help needed for iOS device, can you help me test it? |
|
thanks for the update. I can't test it right now, but maybe another day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed discussion in #1010
Tested on Android system, but not iOS.