-
Notifications
You must be signed in to change notification settings - Fork 13
Remove lifetime from encoding trait #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chipsenkbeil
merged 6 commits into
chipsenkbeil:main
from
fominok:remove-lifetime-from-encoding-trait
Apr 25, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d6ab1f2
lift static restriction for Path methods
fominok facf79c
remove lifetime parameter from encoding trait
fominok 20f1907
fix clippy
fominok d736dfa
Merge remote-tracking branch 'origin' into remove-lifetime-from-encod…
fominok f0cdc33
bump rustc version
fominok 5c3792e
Merge remote-tracking branch 'origin' into remove-lifetime-from-encod…
fominok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ name = "typed-path" | |
| description = "Provides typed variants of Path and PathBuf for Unix and Windows" | ||
| version = "0.10.0" | ||
| edition = "2021" | ||
| rust-version = "1.58.1" | ||
| rust-version = "1.65.0" | ||
| authors = ["Chip Senkbeil <[email protected]>"] | ||
| categories = ["development-tools", "filesystem", "os"] | ||
| keywords = ["unicode", "utf8", "paths", "filesystem"] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
1.65.0the new minimum version that we'll need to support to do this? I was looking at bumping the minimum version, but hadn't done it yet, hence why we support a suuuuuuper old version of1.58.1.Reason I ask is to make sure I know what feature(s) from this new minimum version we need, and also we'll need to update both the Github action - some of the tests run with
1.58.1- and the minimum version referenced in theCargo.tomlfile.I'm actually surprised that the code compiles and passes in Github actions because I thought we had some actions that are using rust
1.58.1explicitly.Anyway, two action items after scanning the contribution - thanks for doing this, btw! - are
Cargo.toml.github/workflows/ci.ymlThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used
cargo msrv findand it figured out that 1.65.0 is the version, which makes sense as there GATs were stabilizedWhy it can pass CI on earlier versions I have no idea, unless those are nightly, where GATs could be for a while longer before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fominok I just merged a tiny PR that switches the github action being used to install the Rust toolchain. Reading the logs, seems like while it installed the minimum version it never switched to using it, hence not hitting errors.
So rebase your PR and then go in and update the minimum version from 1.58.1 to 1.65.0. This way, we can see it go from not compiling to compiling :)