Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/auth architecture cleanup #283

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

Dan-Y-Ko
Copy link
Contributor

Description

I cleaned up unused code and refactored some of the types. No new behavior or functionality expected.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 0:34am

@Dan-Y-Ko Dan-Y-Ko requested a review from timothyrusso January 15, 2025 00:36
@Dan-Y-Ko
Copy link
Contributor Author

@timothyrusso Please review this by Thursday, January 16

Copy link
Contributor

@timothyrusso timothyrusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ok for me

@Dan-Y-Ko Dan-Y-Ko merged commit 5063656 into v0.2.0 Jan 16, 2025
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the refactor/auth-architecture-cleanup branch January 16, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants