Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix add/remove vote bug #250

Closed
wants to merge 2 commits into from
Closed

Conversation

JaneMoroz
Copy link
Contributor

Description

So, you can actually recreate it in development. I believe it might be a backend bug, but adding some timeouts fixes it on our end.

Issue link

Fixes #192

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Sep 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 2:54pm

@Dan-Y-Ko
Copy link
Contributor

Dan-Y-Ko commented Sep 10, 2024

This doesn't fix it. So this issue occurs when testing on the deployed version, so it'd be hard for you to test that since you don't have access. For now I will just say, the issue is still there

Also to confirm if it really is a backend issue, you could create a dummy project that is just using react (so no server action nonsense) and implement this add/remove functionality with a simple button and making the api call. I personally think it's some weird nextjs issue and / or with vercel.

@Dan-Y-Ko Dan-Y-Ko closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with clicking on add/remove vote and clicking it again immediately
2 participants