You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
PPF-2059: Skip an empty rename commit during full-name merges #2059
At the reviewed snapshot, merging full-name wrappers containing distinct left and right fields raised NotImplementedError. __add__() unconditionally called other.commit_widget_key_updates(), even with no queued renames. Page slices that merge wrappers can encounter the same failure.
Work
In wrapper.py, avoid the unsupported full-name rename path when no rename is queued. Preserve the explicit limitation for an actual unsupported rename rather than suppressing all errors.
Acceptance Criteria
Full-name wrappers containing distinct left and right fields merge successfully; true collisions still follow an explicit existing or documented limitation. Exercise page slices that rely on merging as well.
Basis and Dependencies
R09. Does not require choosing a new collision policy; E4-02 addresses broader identity and operand behavior.
The behavior above is evidence from the source review, not a new reproduction performed when filing this issue. Reconfirm the relevant baseline or document intervening changes before implementation. Follow the plan's completion and validation rules and the Developer Guide, including meaningful regression assertions for behavior changes.
changed the title [-]Skip an empty rename commit during full-name merges[/-][+]PPF-2059: Skip an empty rename commit during full-name merges[/+]on Oct 11, 2026
Activity
[-]Skip an empty rename commit during full-name merges[/-][+]PPF-2059: Skip an empty rename commit during full-name merges[/+]