Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/handlers/response-interceptor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,15 +95,7 @@ function copyHeaders(originalResponse, response) {
keys = keys.filter((key) => !['content-encoding', 'transfer-encoding'].includes(key));

keys.forEach((key) => {
let value = originalResponse.headers[key];

if (key === 'set-cookie') {
// remove cookie domain
value = Array.isArray(value) ? value : [value];
value = value.map((x) => x.replace(/Domain=[^;]+?/i, ''));
}

response.setHeader(key, value);
response.setHeader(key, originalResponse.headers[key]);
});
} else {
response.headers = originalResponse.headers;
Expand Down
10 changes: 10 additions & 0 deletions test/e2e/response-interceptor.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,16 @@ describe('responseInterceptor()', () => {
.expect('set-cookie', /.*cookie=monster.*/)
.expect(302);
});

it('should proxy and return original domain of set-cookie headers', async () => {
return agent
.get(
`/response-headers?set-cookie=${encodeURIComponent(
'JSESSIONID=monster;Domain=httpbin.com;Path=/;SameSite=Lax'
)}`
)
.expect('set-cookie', /.*Domain=httpbin.com.*/);
});
});

describe('intercept compressed responses', () => {
Expand Down