feat(session): support incremental resume when head commit moves (#854) - #31
feat(session): support incremental resume when head commit moves (#854)#31chethanuk wants to merge 1 commit into
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 58 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (62)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f909007 to
8b7e849
Compare
codeant-ai
Bot
added
the
size:M
User descriptionFork PR for alibaba#854 incremental review resume. CodeAnt-AI DescriptionResume range reviews incrementally when the head commit moves What Changed
Impact
💡 Usage GuideChecking Your Pull RequestEvery time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later. Talking to CodeAnt AIGot a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask: This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code. ExamplePreserve Org Learnings with CodeAntYou can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input: This helps CodeAnt AI learn and adapt to your team's coding style and standards. ExampleRetrigger reviewAsk CodeAnt AI to review the PR again, by typing: Check Your Repository HealthTo analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health. |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| if req.PerFileMaxTokens != m.Execution.PerFileMaxTokens { | ||
| return fmt.Errorf("per-file max token ceiling changed (parent: %d, requested: %d); %s", m.Execution.PerFileMaxTokens, req.PerFileMaxTokens, resumeHint) | ||
| } | ||
| } else if m.Input.SourceArtifactSHA256 != id.SourceArtifactSHA256 { |
There was a problem hiding this comment.
Suggestion: Normal resumes never compare the newly recorded PerFileMaxTokens value. If the ceiling changes but the selected file set remains the same, SourceArtifactSHA256 can remain identical, allowing checkpoints generated with a different prompt-token limit to be reused. Compare the per-file ceiling for all resume modes, while retaining the additional base-commit checks only for incremental resumes. [api mismatch]
Severity Level: Major ⚠️
- ❌ Normal resumes accept changed per-file token ceilings.
- ⚠️ Reused checkpoints may reflect different prompt limits.
- ⚠️ Review output becomes inconsistent across resumed files.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** internal/session/resume_identity.go
**Line:** 131:131
**Comment:**
*Api Mismatch: Normal resumes never compare the newly recorded `PerFileMaxTokens` value. If the ceiling changes but the selected file set remains the same, `SourceArtifactSHA256` can remain identical, allowing checkpoints generated with a different prompt-token limit to be reused. Compare the per-file ceiling for all resume modes, while retaining the additional base-commit checks only for incremental resumes.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix1 participant
Fork PR for alibaba#854 incremental review resume.