Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter tags to releases with assets #8

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

safinn
Copy link
Contributor

@safinn safinn commented Aug 4, 2024

Fixes #7

Looked at the tags in the flyctl repository and tried to limit to the releases only, which contain assets to download. They create lots of tags that are not "releases".

  • Filter to remove any tags that include a letter or begin with 4 digits. Their releases right now are of the format 0.2.104.
  • Get the latest version from the API and after sorting, stop listing versions once the latest from the API is reached. This should guarantee there are assets to download. Currently there is a tag of 0.2.105 that matches the release version format but has no assets, is not marked as a release on Github and the API still returns 0.2.104 as the latest.
$ mise ls-remote flyctl
...
0.2.99
0.2.100
0.2.101
0.2.102
0.2.103
0.2.104

@safinn safinn changed the title Filter down to releases and sort correctly Filter down to releases Aug 4, 2024
@safinn safinn force-pushed the main branch 3 times, most recently from 2177889 to f06a6d9 Compare August 4, 2024 10:00
@safinn safinn changed the title Filter down to releases Filter tags to releases with assets Aug 4, 2024
@chessmango
Copy link
Owner

Ooh, thanks! Been thinking about how to solve this, but time is... not my friend. Looks like just some shfmt left. :D

@safinn
Copy link
Contributor Author

safinn commented Aug 13, 2024

Thanks for pointing that out. shfmt should now be happy.

@chessmango chessmango merged commit e87344f into chessmango:main Aug 15, 2024
4 checks passed
@chessmango
Copy link
Owner

Hooray for latest working again. Thanks very much for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download Fails
2 participants