Fix stubtest failures in type stub files #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current CI failures are unrelated to the changes in this PR. I will be proposing fixes for the other failures in a separate PR. |
|
Add a change note? |
julianz-
force-pushed
the
stubtest_fixes
branch
from
f113141 to
f18d736
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
==========================================
- Coverage 79.31% 79.19% -0.12%
==========================================
Files 29 29
Lines 4197 4197
Branches 538 538
==========================================
- Hits 3329 3324 -5
- Misses 726 728 +2
- Partials 142 145 +3 |
julianz-
force-pushed
the
stubtest_fixes
branch
2 times, most recently
from
cd2abfd to
7ca72ce
Compare
webknjaz
reviewed
Oct 5, 2025
webknjaz
reviewed
Oct 5, 2025
julianz-
force-pushed
the
stubtest_fixes
branch
3 times, most recently
from
891b9d3 to
1cc32ce
Compare
Added missing __all__ declarations to server.pyi and threadpool.pyi to match their corresponding Python modules. Removed cheroot.connections.IS_WINDOWS from stubtest allowlist and added to connections.pyi to fix environment-dependent stubtest failures These changes resolve stubtest validation errors that were preventing CI from passing due to mismatched public API declarations between stub files and runtime modules.
julianz-
force-pushed
the
stubtest_fixes
branch
from
1cc32ce to
2b7397d
Compare
webknjaz
reviewed
Oct 6, 2025
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
|
@julianz- I've also moved the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing
__all__declarations to server.pyi and threadpool.pyi to match their corresponding Python modules. Removed cheroot.connections.IS_WINDOWS from stubtest allowlist and added to connections.pyi to fix environment-dependent stubtest failuresThese changes resolve stubtest validation errors that were preventing CI from passing due to mismatched public API declarations between stub files and runtime modules.
This change is