Skip to content

Conversation

Afonne-CID
Copy link

@Afonne-CID Afonne-CID commented Sep 23, 2025

Confirmed via a sweep (using uv) across Python 3.10–3.13, ignore:path is deprecated … :DeprecationWarning:certifi.core, ResourceWarning: unclosed <ssl.SSLSocket …> and PytestUnraisableExceptionWarning: Exception ignored in <function IOBase.__del__ …> are now all obsolete warning ignores as the deprecations no longer trigger in any of these Python versions.

So far, on my test, these mentioned suppressions are safe to remove without any additional code changes, but let's see what the CI thinks.

What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

📋 What is the related issue number (starting with #)

Related to #768

What is the current behavior? (You can also link to an open issue here)
Pytest is configured to suppress certain warnings (DeprecationWarning, ResourceWarning, PytestUnraisableExceptionWarning) that no longer occur on supported Python versions.

What is the new behavior (if this is a feature change)?
Those warning ignores are removed; test output is cleaner, and we rely on CI to confirm no regressions.

📋 Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

The underlying issues that were causing these warnings
have been resolved.
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.03%. Comparing base (7eced3d) to head (50bdcd7).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   79.24%   78.03%   -1.22%     
==========================================
  Files          29       29              
  Lines        4197     4197              
  Branches      538      538              
==========================================
- Hits         3326     3275      -51     
- Misses        727      767      +40     
- Partials      144      155      +11     

@Afonne-CID Afonne-CID marked this pull request as draft September 24, 2025 18:27
@webknjaz
Copy link
Member

using uv

Those Pythons are built differently than normally shipped versions. There will be differences in behavior, sometimes unnoticable.

Also, you may want to drop the ignores in separate PRs to see if some of them would be fine in our CI, in isolation from other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants