Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

优化static const 变量，减少代码量 #450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

优化static const 变量，减少代码量 #450

wants to merge 1 commit into from

Conversation

jiapengwen
Copy link

No description provided.

@chenshuo
Copy link
Owner

你这个 PR 让所有使用 muduo/net/Channel.h 的文件都 include 了 <poll.h>，我不认为是合适的做法。

@jiapengwen
Copy link
Author

按照我的理解，头文件包含 <poll.h>只会增加编译结果的size，应该不会导致编译速度变慢，不知道我理解的对不对

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiapengwen @chenshuo