Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating FFI support #1863

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Updating FFI support #1863

wants to merge 7 commits into from

Conversation

johnmccrae
Copy link
Contributor

Description

Ohai hasn't been updated in a bit. It's current dependency on a stale version of ffi is causing errors in Chef-19. We also needed to update the supported Ruby versions

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

John McCrae added 2 commits February 6, 2025 09:37
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
@johnmccrae johnmccrae requested review from a team as code owners February 6, 2025 17:42
John McCrae added 5 commits February 6, 2025 13:17
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@tpowell-progress
Copy link
Contributor

@johnmccrae looks like you still have the cookstyle load error due to racc/parser not being available.

Copy link
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install_if racc if >= 3.3 ruby version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants