add commercial api support #408
Open
+1,724
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stromweld
added
the
Expeditor: Bump Version Minor
Stromweld
force-pushed
the
commercial-api
branch
2 times, most recently
from
213fa76 to
bdd5108
Compare
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Stromweld
force-pushed
the
commercial-api
branch
from
2e471f6 to
069f89b
Compare
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Contributor
|
Thanks for adding the ADR upon request! Will take a while to go through this PR. |
sean-sype-simmons
requested changes
Jan 8, 2026
Signed-off-by: Stromweld <[email protected]>
… api Signed-off-by: Stromweld <[email protected]>
tas50
reviewed
Jan 10, 2026
jaymzh
reviewed
Jan 10, 2026
Collaborator
jaymzh
left a comment
jaymzh
left a comment
There was a problem hiding this comment.
I reviewed the ruby well, but only scanned through the shell stuff. Only one small comment
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
jaymzh
reviewed
Jan 12, 2026
Signed-off-by: Corey Hemminger <[email protected]>
sean-sype-simmons
approved these changes
Jan 13, 2026
jaymzh
reviewed
Jan 13, 2026
…ental Signed-off-by: Corey Hemminger <[email protected]>
|
johnmccrae
reviewed
Jan 13, 2026
| { $_ -ge [version]'6.3.0' } { '2012r2'; break } | ||
| { $_ -ge [version]'6.2.0' } { '2012'; break } | ||
| { $_ -ge [version]'6.1.0' } { '2008r2'; break } | ||
| { $_ -ge [version]'6.0.0' } { '2008'; break } |
There was a problem hiding this comment.
Hi, lines 12 - 15 can die - we don't support those versions anymore. Please add a version for 2025 - 10.0.26100.32230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add commercial api support with licensed downloads
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.