Skip to content

Conversation

@Stromweld
Copy link
Contributor

Description

Add commercial api support with licensed downloads

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Stromweld Stromweld self-assigned this Jan 1, 2026
@Stromweld Stromweld added the Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. label Jan 1, 2026
@Stromweld Stromweld force-pushed the commercial-api branch 2 times, most recently from 213fa76 to bdd5108 Compare January 6, 2026 22:10
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Stromweld <[email protected]>
@sean-sype-simmons
Copy link
Contributor

Thanks for adding the ADR upon request! Will take a while to go through this PR.

Signed-off-by: Stromweld <[email protected]>
@Stromweld Stromweld marked this pull request as ready for review January 9, 2026 18:51
@Stromweld Stromweld requested review from a team and jaymzh as code owners January 9, 2026 18:51
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the ruby well, but only scanned through the shell stuff. Only one small comment

Signed-off-by: Corey Hemminger <[email protected]>
@sean-sype-simmons sean-sype-simmons self-requested a review January 13, 2026 21:06
@sonarqubecloud
Copy link

{ $_ -ge [version]'6.3.0' } { '2012r2'; break }
{ $_ -ge [version]'6.2.0' } { '2012'; break }
{ $_ -ge [version]'6.1.0' } { '2008r2'; break }
{ $_ -ge [version]'6.0.0' } { '2008'; break }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, lines 12 - 15 can die - we don't support those versions anymore. Please add a version for 2025 - 10.0.26100.32230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants