add commercial api support #408
Conversation
Stromweld
added
the
Expeditor: Bump Version Minor
Stromweld
force-pushed
the
commercial-api
branch
2 times, most recently
from
213fa76 to
bdd5108
Compare
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Stromweld
force-pushed
the
commercial-api
branch
from
2e471f6 to
069f89b
Compare
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
Signed-off-by: Stromweld <[email protected]>
|
Thanks for adding the ADR upon request! Will take a while to go through this PR. |
Signed-off-by: Stromweld <[email protected]>
… api Signed-off-by: Stromweld <[email protected]>
jaymzh
left a comment
jaymzh
left a comment
There was a problem hiding this comment.
I reviewed the ruby well, but only scanned through the shell stuff. Only one small comment
| | Chef Infra Client | chef | | ||
| | Chef Backend | chef-backend | | ||
| | Chef Foundation | chef-foundation | | ||
| | Chef Infra Client Enterprise | chef-ice | |
There was a problem hiding this comment.
maybe not the best abbreviation. chef-e?
There was a problem hiding this comment.
That's what PM team called it and named the product. Granted it was before all the current political events.
There was a problem hiding this comment.
Regardless of where we end up with this I just noticed that there's no way to know these names when using the CLI. There is no help that lists them, so we should add a list-products command.
There was a problem hiding this comment.
I feel like that should be a seperate PR since this has never had that previously and isn't in scope of adding the new commercial api support.
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
| 5. **Backward Compatibility**: Maintains complete backward compatibility with existing Omnitruck-based installations when no license_id is provided | ||
|
|
||
| 6. **Cross-Platform Support**: Works seamlessly across all supported platforms and download methods: | ||
| 5. **Cross-Platform Support**: Works seamlessly across all supported platforms and download methods: |
There was a problem hiding this comment.
Markdown says use all 1. so that we don't have to go through these re-numbering exerecises - it's rendered properly.
There was a problem hiding this comment.
How does that impact or is there an impact to copilot and AI? Since these are instructions to add context for copilot when working with the code will markdown changes like that affect it? Otherwise probably best to just add it to exception list for markdown linting.
Signed-off-by: Corey Hemminger <[email protected]>
|
Description
Add commercial api support with licensed downloads
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.