Fix Ruby build and add runtime Gemfile.lock generation support #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
- Add run-bundle-install parameter to enable bundle install before SBOM scan - Products without committed Gemfile.lock can now generate it at runtime - Add Ruby setup step in ci-build job for Ruby projects - Pass run-bundle-install parameter through workflow chain
…step - Change condition from language/build-profile to run-bundle-install parameter - Remove --deployment and --path flags that require existing lockfile - Remove bundle exec rake build - only need lockfile for SBOM scan - Rename step to clarify purpose: Generate Gemfile.lock for SBOM scanning
- Added new input parameter run-bundle-install to support generating Gemfile.lock at runtime - This enables BlackDuck SCA scanning for projects like chef-cli that don't commit lockfiles - Parameter passed through to sbom.yml workflow for lockfile generation before scanning
…d error - Install Ruby 3.4 using ruby/setup-ruby@v1 before running bundle commands - Fixes broken Ruby build in ci-build job that has existed since main branch creation - Enables build to complete successfully so SBOM job can run - Works in conjunction with run-bundle-install parameter for runtime Gemfile.lock generation
- Remove --deployment flag from bundle install when no Gemfile.lock exists - --deployment flag requires existing Gemfile.lock, causing exit code 16 - Fix typo: .gemlock -> Gemfile.lock in echo message
Signed-off-by: nikhil2611 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes broken Ruby builds in the main branch and adds support for generating Gemfile.lock at runtime for projects that don't commit their lockfiles.
Changes Made
1. Fixed Broken Ruby Build (ci-build job)
2. Added Runtime Gemfile.lock Generation (sbom.yml)
Testing
✅ Tested on chef-cli repository
✅ BlackDuck scan: RUBYGEMS: SUCCESS
✅ Gemfile.lock successfully created at runtime
TODO Before Merging