Fixed: Vault warns when valid JSON contains special character sequences

[decoyjoe]

Description

Fixes an issue where Chef Vault writes a warning when a valid JSON document contains special character sequences, exposing sensitive vault data in the warning message.

Chef Vault should be agnostic to the content of the vault item JSON. It no longer inspects vault item contents, validation responsibility is left to the JSON parser to ensure the JSON data is valid.

Related Issue

Fixes #415 Chef Vault warns and leaks secrets when vault json contains properly encoded special characters · Issue #415 · chef/chef-vault

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[decoyjoe]

Additional context around this issue can be found in:

• Fixed problem escaping string in JSON by sanga1794 · Pull Request #347 · chef/chef-vault
• Revert #347 by josqu4red · Pull Request #375 · chef/chef-vault
• attempt to fix once and for all the issue with json validation introduced with version 4.0.13 by jkimalane · Pull Request #384 · chef/chef-vault

[jaymzh]

Looks good minus a few typos

[jaymzh]

assuming tests pass, I'm good with this.

[jaymzh]

Hey @johnmccrae - I think this is related to powershell stuff?

[jaymzh]

Just to keep people following this PR up-to-date, I followed up in Slack on this. The team is aware - but the pipelines here need some significant investigation to sort out. I've asked for a timeline estimate.

[tpowell-progress]

https://github.com/chef/chef-vault/pull/435/files @jaymzh @decoyjoe fyi, I believe this is the work to fix the pipeline.

[decoyjoe]

Branch has been rebased on latest from main.

[decoyjoe]

@tpowell-progress @jaymzh it looks like the pipeline has been fixed. Could we get another review on this?

[jaymzh]

Yeah, just approved workflows, if they pass, we'll merge it today.

[jaymzh]

OH, we'll need workstation approvers. Will have THomas ping them in the meeting today.

[ashiqueps]

@decoyjoe It looks like the branch is out of date with the main. Could you please do a rebase with the main?

[decoyjoe]

@ashiqueps Rebased on main.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nikhil2611]

@ashiqueps Rebased on main.

@decoyjoe , still I see this branch is out-of-date with the base branch

[decoyjoe]

@nikhil2611 Oops, sorry. It's actually rebased now.