Skip to content

Don't use hardcoded AMD64 architecture for paths in build scripts - #365

Merged
johnmccrae merged 1 commit into
mainfrom
jfm/main-build-script-hardening
Sep 4, 2026
Merged

johnmccrae merged 1 commit into
mainfrom
jfm/main-build-script-hardening

Conversation

@johnmccrae

Copy link
Copy Markdown
Contributor

Cherry-picked build-script portion of 18-Stable commit 234b838 (#350):

  • build_gems.ps1 / manual_gem_release.ps1 resolve PROCESSOR_ARCHITECTURE dynamically instead of hardcoding AMD64
  • update_version.ps1 resolves project root via 'git rev-parse --show-toplevel' instead of a full C:\ recursive scan

The Ruby runtime portion of 234b838 is not included since main's ChefPowerShell.bin_dir already supersedes it.

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Cherry-picked build-script portion of 18-Stable commit 234b838 (#350):
- build_gems.ps1 / manual_gem_release.ps1 resolve PROCESSOR_ARCHITECTURE
  dynamically instead of hardcoding AMD64
- update_version.ps1 resolves project root via 'git rev-parse
  --show-toplevel' instead of a full C:\ recursive scan

The Ruby runtime portion of 234b838 is not included since main's
ChefPowerShell.bin_dir already supersedes it.

Signed-off-by: John McCrae <mccrae@progress.com>
@johnmccrae
johnmccrae force-pushed the jfm/main-build-script-hardening branch from 25f9c3f to c52d20a Compare September 2, 2026 14:51
@johnmccrae
johnmccrae merged commit 43ad27e into main Sep 4, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants