Skip to content
This repository was archived by the owner on Feb 23, 2022. It is now read-only.

Conversation

iamjada
Copy link

@iamjada iamjada commented Jan 28, 2022

CEM-2599
Removed unused table props and added initials on top of chair.

Screen Shot 2022-01-27 at 5 24 08 PM

@iamjada iamjada requested a review from ralph-dev January 28, 2022 01:26
Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't only the top chair leg have props and not the bottom leg? Better yet, why not just have ChairLegProps so they stay in sync ;)

@iamjada
Copy link
Author

iamjada commented Jan 28, 2022

Added ChairLegProps to top and bottom chair legs. Created a Personalized Chair with square legs.
Screen Shot 2022-01-27 at 7 48 53 PM

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I would just add back chair props and seat props as well

@ralph-dev
Copy link
Member

backChairProps

Als ways add the s

@ralph-dev
Copy link
Member

Also why do you need a div and chair body can one of them be removed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants