Skip to content
This repository was archived by the owner on Feb 23, 2022. It is now read-only.

Conversation

@roggc
Copy link
Contributor

@roggc roggc commented Jan 22, 2022

this is fileuploav2 with the components just developed, dropArea and panelCard, and without the list wrapper component for panelCard, just in case you want to look at it how it looks.

fileuploadv2bis

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality

Comment on lines 159 to 160
if (informativePanels.startWorkers.length) {
informativePanels.startWorkers.forEach((name) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate code use destructing

Comment on lines 180 to 181
if (informativePanels.makeItDisappear.length) {
informativePanels.makeItDisappear.forEach((name) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up functions

name={panel.name}
operationState={panel.operationState}
margin="10px 0"
style={{width:dropAreaWidth,boxSizing:'border-box'}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styled comp

@roggc roggc requested a review from ralph-dev January 23, 2022 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants