Skip to content
This repository was archived by the owner on Feb 23, 2022. It is now read-only.

Conversation

@iamjada
Copy link

@iamjada iamjada commented Nov 10, 2021

Created a chair using HTML & CSS
Screen Shot 2021-11-09 at 9 11 03 PM

@iamjada iamjada requested a review from ralph-dev November 10, 2021 05:13
@iamjada iamjada self-assigned this Nov 10, 2021
Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on in meeting review changes


type Position = 'top' | 'bottom' | 'left' | 'right';

export interface IAdvancedChair {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re use existing interface

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story is missing action() and arguments

@ralph-dev
Copy link
Member

Update the picture to showcase the different states btw

@iamjada
Copy link
Author

iamjada commented Nov 18, 2021

Before clicking the chair
Screen Shot 2021-11-17 at 4 49 26 PM
After the chair is clicked
Screen Shot 2021-11-17 at 4 49 35 PM

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix colors

@iamjada
Copy link
Author

iamjada commented Nov 24, 2021

Screen Shot 2021-11-23 at 4 47 10 PM

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ralph-dev
Copy link
Member

Props need a description

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants