Rebased PR: add docker compose for installing a chatmail relay #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missytake
force-pushed
the
sshexec-docker
branch
2 times, most recently
from
c35f186 to
a1c2870
Compare
missytake
force-pushed
the
sshexec-rework
branch
from
89ba4b5 to
ae7ec25
Compare
missytake
force-pushed
the
docker-rebase
branch
from
e6c6931 to
e61239f
Compare
missytake
force-pushed
the
docker-rebase
branch
from
e61239f to
2f4cfcc
Compare
missytake
force-pushed
the
docker-rebase
branch
from
2f4cfcc to
d12782f
Compare
- Adds configuration parameters (`change_kernel_settings`, `fs_inotify_max_user_instances_and_watchers`)
missytake
force-pushed
the
docker-rebase
branch
from
d12782f to
8541139
Compare
Keonik1
reviewed
Oct 26, 2025
| ```shell | ||
| cp ./docker/docker-compose-default.yaml docker-compose.yaml | ||
| ``` | ||
|
|
There was a problem hiding this comment.
We missed the second step - creating .env file.
Yes, it's trivial, but not all users will immediately understand what to do (I personally know some who don't). Therefore, it is better to write this in the instructions so that it is as close as possible to the copy-paste-work format.
Suggested change
| 2. Copy `./docker/example.env` and rename it to `.env`. This file stores variables used in `docker-compose.yaml`. | |
| ```shell | |
| cp ./docker/example.env .env | |
| ```\ |
| ```shell | ||
| cp ./docker/docker-compose-default.yaml docker-compose.yaml | ||
| ``` | ||
|
|
There was a problem hiding this comment.
same
Suggested change
| 2. Скопировать `./docker/example.env` и переименовать в `.env`. Здесь хранятся переменные, которые используются в `docker-compose.yaml`. | |
| ```shell | |
| cp ./docker/example.env .env | |
| ```\ |
|
So, I found some more problems with the installation via Docker, some of which seem to be related to changes that were lost during the transfer. |
|
I created an issue with the main problem. |
Keonik1
reviewed
Oct 26, 2025
|
|
||
| ### MAIN | ||
|
|
||
| if [ "$DEBUG_COMMANDS_ENABLED" == "true" ]; then |
There was a problem hiding this comment.
Suggested change
| if [ "$DEBUG_COMMANDS_ENABLED" == "true" ]; then | |
| if [ "$DEBUG_COMMANDS_ENABLED" = true ]; then |
| debug_commands | ||
| fi | ||
|
|
||
| if [ "$FORCE_REINIT_INI_FILE" == "true" ]; then |
There was a problem hiding this comment.
Suggested change
| if [ "$FORCE_REINIT_INI_FILE" == "true" ]; then | |
| if [ "$FORCE_REINIT_INI_FILE" = true ]; then |
|
|
||
| # TODO: Move to debug_commands after git clone is moved to dockerfile. | ||
| git config --global --add safe.directory /opt/chatmail | ||
| if [ "$RECREATE_VENV" == "true" ]; then |
There was a problem hiding this comment.
Suggested change
| if [ "$RECREATE_VENV" == "true" ]; then | |
| if [ "$RECREATE_VENV" = true ]; then |
| fi | ||
| ./scripts/initenv.sh | ||
|
|
||
| ./scripts/cmdeploy init --config "${INI_FILE}" $INI_CMD_ARGS $MAIL_DOMAIN |
There was a problem hiding this comment.
Suggested change
| ./scripts/cmdeploy init --config "${INI_FILE}" $INI_CMD_ARGS $MAIL_DOMAIN | |
| ./scripts/cmdeploy init --config "${INI_FILE}" $INI_CMD_ARGS $MAIL_DOMAIN || true |
| ./scripts/cmdeploy init --config "${INI_FILE}" $INI_CMD_ARGS $MAIL_DOMAIN | ||
| bash /update_ini.sh | ||
|
|
||
| ./scripts/cmdeploy run --ssh-host docker |
There was a problem hiding this comment.
Suggested change
| ./scripts/cmdeploy run --ssh-host docker | |
| ./scripts/cmdeploy run --ssh-host @docker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @Keonik1 for #614 :) I had a lot of fun with
git rebaseto break it up into small, reviewable chunks. It's still a lot, but doable :)Before we can merge this, we need to merge:
cmdeploy runoption to skip DNS checks #661Additional related PRs:
With this PR, checking DNS records should already work; Getting tests to run with a docker instance is still a bit of work (see the docker-rebase...docker-tests branch for first steps).
So for now this will be an experimental feature which we can tell people to try out if they ask for it. But in the long term we need a separate CI machine for testing the docker setup, to be sure nothing breaks when we make changes.