fix: fixes for transport JsonRPC #6680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
changed the title
|
LGTM now. @adbenitez @link2xt wanna review? |
link2xt
reviewed
Mar 20, 2025
| "addr": addr, | ||
| "password": password, | ||
| "imapSecurity": "starttls", | ||
| "smptSecurity": "starttls", |
There was a problem hiding this comment.
Why does this "smpt" pass? Should be "smtp" in any case.
There was a problem hiding this comment.
Hmm, probably invalid values here are silently ignored?
link2xt
reviewed
Mar 20, 2025
|
@link2xt @adbenitez do I get an approval for the rust part? The python part (which @adbenitez wrote) LGTM |
link2xt
approved these changes
Mar 25, 2025
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6582, individual commits revieweable