test: use vCards in TestContext.add_or_lookup_contact
#6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
changed the title
add_or_lookup_contactTestContext.add_or_lookup_contact
link2xt
force-pushed
the
link2xt/vcard-groups
branch
from
41c3263 to
f0f06af
Compare
link2xt
force-pushed
the
link2xt/vcard-groups
branch
3 times, most recently
from
4bda47b to
c4b8271
Compare
link2xt
force-pushed
the
link2xt/vcard-groups
branch
from
c4b8271 to
7b1d893
Compare
iequidoo
approved these changes
Mar 20, 2025
link2xt
force-pushed
the
link2xt/contact-set-name
branch
from
6684c0c to
06f6471
Compare
link2xt
force-pushed
the
link2xt/vcard-groups
branch
from
7b1d893 to
a7f1683
Compare
link2xt
force-pushed
the
link2xt/vcard-groups
branch
2 times, most recently
from
2f5df17 to
acf0d19
Compare
The test is mostly testing that groups can be matched even if Message-ID is replaced. Delta Chat no longer places group ID into Message-ID or References, so the test is not testing anything other than the ability to match groups based on References header.
This avoids importing the key via vCard as a side effect of looking for a chat.
link2xt
force-pushed
the
link2xt/vcard-groups
branch
from
acf0d19 to
d38b7cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6685