Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python and tox to flake.nix devshell #6233

Merged
merged 2 commits into from
Apr 1, 2025
Merged

Conversation

Septias
Copy link
Collaborator

@Septias Septias commented Nov 20, 2024

Without tox any python scripts/make-python-env.sh does not run. Maybe at some point we can even generate the environment for testing with venvHook like functionality. We could also add python3 instead of fixing it to 3.11, but I don't know which version core expects

@Septias Septias requested a review from link2xt November 20, 2024 10:39
Without tox any python `scripts/make-python-env.sh` does not run. Maybe
at some point we can even generate the environment for testing with
`venvHook` like functionality.
@Septias Septias force-pushed the sk/add_python_and_tox branch from 00d64e5 to c042cf4 Compare March 31, 2025 10:14
@Septias
Copy link
Collaborator Author

Septias commented Mar 31, 2025

@link2xt this was stall forever, lets merge or close this

Copy link
Collaborator

@link2xt link2xt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better use python 3 and not pin to 3.11.

@Septias Septias enabled auto-merge (squash) April 1, 2025 21:03
@Septias Septias merged commit 1ba0dd5 into main Apr 1, 2025
67 checks passed
@Septias Septias deleted the sk/add_python_and_tox branch April 1, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants