Correctly escape messages consisting of a dot in SMTP protocol #3265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
send-single-dot
branch
from
a168f2b to
47af34e
Compare
r10s
approved these changes
Apr 30, 2022
|
note that the python test failing seems directly related to the PR so this should not be merged without addressing the failure. |
The test is failing because async-smtp in Cargo.lock is not updated in this PR. |
link2xt
force-pushed
the
send-single-dot
branch
from
47af34e to
7362a8c
Compare
Actual bugfix is in the async-smtp crate.
link2xt
force-pushed
the
send-single-dot
branch
from
7362a8c to
48f2c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual bugfix is in the async-smtp crate.
Depends on chatmail/async-smtp#49
Fixes #2635