Add pipelining extension support #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not as useful as it could be because of incorrect buffering. We should attach |
Hocuri
approved these changes
Jan 8, 2023
src/smtp/client/inner.rs
Outdated
| @@ -238,12 +238,27 @@ impl<S: Connector + Write + Read + Unpin> InnerClient<S> { | |||
| self.command_with_timeout(command, timeout.as_ref()).await | |||
| } | |||
|
|
|||
| /// Sends the given SMTP command to the server without waiting for response. | |||
| pub async fn send_command<C: Display>(self: Pin<&mut Self>, command: C) -> Result<(), Error> { | |||
There was a problem hiding this comment.
I think that this should be called send_command_no_timeout, like read_response_no_timeout (read_response uses self.timeout)
src/smtp/client/inner.rs
Outdated
Comment on lines
242
to
244
| pub async fn send_command<C: Display>(self: Pin<&mut Self>, command: C) -> Result<(), Error> { | ||
| self.write(command.to_string().as_bytes()).await | ||
| } |
There was a problem hiding this comment.
This function is actually never used (or, only in send_command_with_timeout where it could be inlined), but you added it for completeness?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48