Update fast-socks5 dependency #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mre
added a commit
to lycheeverse/check-if-email-exists
that referenced
this pull request
Feb 8, 2021
This includes updating Tokio to 1.x. The feature flags of Tokio have been changed and `dns` was merged into `net`. `fast-socks5` was used in two different versions because of a dependency in async-smtp. This gets addressed in chatmail/async-smtp#36, but in the meantime we can divert to the fix from the fork at https://github.com/amaurymartiny/async-smtp/tree/am-fast-socks.
amaury1093
pushed a commit
to reacherhq/check-if-email-exists
that referenced
this pull request
Feb 8, 2021
* Update dependencies This includes updating Tokio to 1.x. The feature flags of Tokio have been changed and `dns` was merged into `net`. `fast-socks5` was used in two different versions because of a dependency in async-smtp. This gets addressed in chatmail/async-smtp#36, but in the meantime we can divert to the fix from the fork at https://github.com/amaurymartiny/async-smtp/tree/am-fast-socks. * Use SmallRng, which is Send+Sync Hyper requires shared types to be Send+Sync. The threaded rng is not. Replacing it with SmallRng does the trick, which is satisfactory for creating random mail addresses. * cargo fmt * Mark tests with tokio_test * Update hyper * Update test suite to Tokio 1.x
|
Gentle ping on this PR 🙏 |
flub
approved these changes
Feb 10, 2021
21 tasks
|
@dignifiedquire can we merge this? It's currently blocking the homebrew release of lychee. 😕 |
dignifiedquire
approved these changes
Mar 15, 2021
|
Thanks @dignifiedquire, any chance we can get a 0.3.5? |
|
Yup, a new 0.3.5 release would be mega @dignifiedquire. Sorry for being so pushy, but our downstream crates depend on it for their next releases. 😅 |
|
finally got around to publishing |
|
Thanks! |
coinbest90726
added a commit
to coinbest90726/check-email
that referenced
this pull request
Apr 26, 2024
* Update dependencies This includes updating Tokio to 1.x. The feature flags of Tokio have been changed and `dns` was merged into `net`. `fast-socks5` was used in two different versions because of a dependency in async-smtp. This gets addressed in chatmail/async-smtp#36, but in the meantime we can divert to the fix from the fork at https://github.com/amaurymartiny/async-smtp/tree/am-fast-socks. * Use SmallRng, which is Send+Sync Hyper requires shared types to be Send+Sync. The threaded rng is not. Replacing it with SmallRng does the trick, which is satisfactory for creating random mail addresses. * cargo fmt * Mark tests with tokio_test * Update hyper * Update test suite to Tokio 1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.